From: Joel Brobecker <brobecker@adacore.com>
To: Mike Frysinger <vapier@gentoo.org>
Cc: gdb-patches@sourceware.org, pedro@codesourcery.com
Subject: Re: [PATCH 2/2] gdb: gdbserver: bfin: new port
Date: Wed, 08 Dec 2010 21:38:00 -0000 [thread overview]
Message-ID: <20101208213836.GB18023@adacore.com> (raw)
In-Reply-To: <1289867547-19134-2-git-send-email-vapier@gentoo.org>
> gdb/:
> 2010-11-16 Jie Zhang <jie.zhang@analog.com>
>
> * configure.tgt (bfin-*-*): Set build_gdbserver to yes.
> * NEWS: Mention new Blackfin support.
> * regformats/reg-bfin.dat: New file.
>
> gdbserver/:
> 2010-11-16 Jie Zhang <jie.zhang@analog.com>
>
> * configure.srv (bfin-*-*): Handle bfin targets.
> * linux-bfin-low.c: New file.
> * linux-low.c: Define PT_TEXT_ADDR, PT_TEXT_END_ADDR, and
> PT_DATA_ADDR for BFIN targets.
> * Makefile.in (SFILES): Add linux-bfin-low.c.
> (clean): Remove reg-bfin.c.
> (linux-bfin-low.o, reg-bfin.o, reg-bfin.c): New targets.
> * README: Mention supported Blackfin targets.
The best person to approve your change is either Daniel or Pedro.
Pedro has been doing most of the approvals in that area, lately.
Nonetheless, I had a look.
Overall, I don't see anything wrong with the code.
> +#define bfin_num_regs (sizeof(bfin_regmap) / sizeof(bfin_regmap[0]))
You can use ARRAY_SIZE.
> + unsigned long pc;
> + collect_register_by_name (regcache, "pc", &pc);
> + return pc;
Empty line after local variable declarations... There are several
instances in your patch.
--
Joel
next prev parent reply other threads:[~2010-12-08 21:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-16 0:34 [PATCH 1/2] gdb: " Mike Frysinger
2010-11-16 0:34 ` [PATCH 2/2] gdb: gdbserver: " Mike Frysinger
2010-12-08 21:38 ` Joel Brobecker [this message]
2010-11-21 21:29 ` [PATCH 1/2] gdb: " Mike Frysinger
2010-11-29 23:49 ` Mike Frysinger
2010-12-06 10:56 ` Mike Frysinger
2010-12-08 21:25 ` Joel Brobecker
2010-12-08 21:36 ` Eli Zaretskii
2010-12-09 3:35 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101208213836.GB18023@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=pedro@codesourcery.com \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox