From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14183 invoked by alias); 8 Dec 2010 21:38:51 -0000 Received: (qmail 14170 invoked by uid 22791); 8 Dec 2010 21:38:50 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 08 Dec 2010 21:38:46 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id C031D2BAB6B; Wed, 8 Dec 2010 16:38:44 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 4qZBXFsVbvHY; Wed, 8 Dec 2010 16:38:44 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 6E4DD2BAB60; Wed, 8 Dec 2010 16:38:44 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 749E2145B58; Wed, 8 Dec 2010 13:38:36 -0800 (PST) Date: Wed, 08 Dec 2010 21:38:00 -0000 From: Joel Brobecker To: Mike Frysinger Cc: gdb-patches@sourceware.org, pedro@codesourcery.com Subject: Re: [PATCH 2/2] gdb: gdbserver: bfin: new port Message-ID: <20101208213836.GB18023@adacore.com> References: <1289867547-19134-1-git-send-email-vapier@gentoo.org> <1289867547-19134-2-git-send-email-vapier@gentoo.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1289867547-19134-2-git-send-email-vapier@gentoo.org> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-12/txt/msg00098.txt.bz2 > gdb/: > 2010-11-16 Jie Zhang > > * configure.tgt (bfin-*-*): Set build_gdbserver to yes. > * NEWS: Mention new Blackfin support. > * regformats/reg-bfin.dat: New file. > > gdbserver/: > 2010-11-16 Jie Zhang > > * configure.srv (bfin-*-*): Handle bfin targets. > * linux-bfin-low.c: New file. > * linux-low.c: Define PT_TEXT_ADDR, PT_TEXT_END_ADDR, and > PT_DATA_ADDR for BFIN targets. > * Makefile.in (SFILES): Add linux-bfin-low.c. > (clean): Remove reg-bfin.c. > (linux-bfin-low.o, reg-bfin.o, reg-bfin.c): New targets. > * README: Mention supported Blackfin targets. The best person to approve your change is either Daniel or Pedro. Pedro has been doing most of the approvals in that area, lately. Nonetheless, I had a look. Overall, I don't see anything wrong with the code. > +#define bfin_num_regs (sizeof(bfin_regmap) / sizeof(bfin_regmap[0])) You can use ARRAY_SIZE. > + unsigned long pc; > + collect_register_by_name (regcache, "pc", &pc); > + return pc; Empty line after local variable declarations... There are several instances in your patch. -- Joel