From: Joel Brobecker <brobecker@adacore.com>
To: Thiago Jung Bauermann <bauerman@br.ibm.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch 1/2] Convert hardware watchpoints to use breakpoint_ops
Date: Thu, 18 Nov 2010 17:18:00 -0000 [thread overview]
Message-ID: <20101118171834.GD2634@adacore.com> (raw)
In-Reply-To: <1289933508.3202.13.camel@hactar>
> I kept the wording as similar as possible to the original. Your
> suggestion is then to have the code below instead?
>
> + if (val == 1)
> + warning (_("\
> +Error inserting catchpoint %d: Your system does not support this type of catchpoint."),
> + bpt->owner->number);
> + else
> + warning (_("Error inserting catchpoint %d."), bpt->owner->number);
Yep!
> What about these additional comments (I'll send the updated patch after
> understanding your suggestion above)?
They look good to me. IMO, you can even drop the first hunk,
documenting the return value inside the target_ops vector definition.
I'd rather have no documentation than an incomplete duplicate of
the actual documentation located elsewhere. The idea is that, if
there is no documentation, then it might help trigger a search of
that documentation elsewhere. If there is some, then we might not
have the idea to look elsewhere for the rest...
--
Joel
next prev parent reply other threads:[~2010-11-18 17:18 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-17 19:41 Thiago Jung Bauermann
2010-10-07 14:47 ` Thiago Jung Bauermann
2010-10-16 17:43 ` Pedro Alves
2010-10-20 0:31 ` Thiago Jung Bauermann
2010-11-04 21:17 ` Thiago Jung Bauermann
2010-11-08 18:43 ` Joel Brobecker
2010-11-08 21:39 ` Thiago Jung Bauermann
2010-11-15 22:23 ` Joel Brobecker
2010-11-16 19:03 ` Thiago Jung Bauermann
2010-11-18 17:18 ` Joel Brobecker [this message]
2010-11-19 20:10 ` Thiago Jung Bauermann
2010-12-23 19:06 ` Thiago Jung Bauermann
2011-01-11 19:31 ` Thiago Jung Bauermann
2011-04-29 15:51 ` "Cannot remove breakpoints because program is no longer writable" & catchpoints (was: Re: [patch 1/2] Convert hardware watchpoints to use breakpoint_ops) Pedro Alves
2010-11-16 4:06 ` [patch 1/2] Convert hardware watchpoints to use breakpoint_ops Jan Kratochvil
2010-11-16 8:07 ` Joel Brobecker
2010-11-16 18:51 ` Jan Kratochvil
2010-11-17 3:47 ` [patch] Renaming: {insert,remove} += _location [Re: [patch 1/2] Convert hardware watchpoints to use breakpoint_ops] Jan Kratochvil
2010-11-18 17:13 ` Joel Brobecker
[not found] ` <20101117034556.GA12159@host0.dyn.jankratochvil.net>
2010-11-18 17:15 ` [patch] renaming: bp_location: b->bl &co. " Joel Brobecker
2010-12-23 18:50 ` Thiago Jung Bauermann
2010-12-24 5:14 ` Joel Brobecker
2010-12-27 20:04 ` Thiago Jung Bauermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101118171834.GD2634@adacore.com \
--to=brobecker@adacore.com \
--cc=bauerman@br.ibm.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox