From: Joel Brobecker <brobecker@adacore.com>
To: Doug Evans <dje@google.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] value_change_enclosing_type -> set_value_enclosing_type
Date: Mon, 08 Nov 2010 16:41:00 -0000 [thread overview]
Message-ID: <20101108164125.GC2933@adacore.com> (raw)
In-Reply-To: <20101106185152.EE5612461A3@ruffy.mtv.corp.google.com>
> This patch does two things:
> - rename value_change_enclosing_type to set_value_enclosing_type,
> and make the result void, for clarity and consistency with other
> set_value_foo functions
> - have value_full_object always return a new value if it needs to
> modify the input value
>
> I will check it in in a few days if there are no objections.
>
> Tested on amd64-linux, no regressions.
>
> 2010-11-06 Doug Evans <dje@google.com>
>
> * value.c (set_value_enclosing_type): Renamed from
> value_change_enclosing_type. All callers updated.
> * value.h (set_value_enclosing_type): Update.
> * valops.c (value_full_object): Always return a copy if we need to
> make changes to the input value.
FWIW, I like this change.
--
Joel
prev parent reply other threads:[~2010-11-08 16:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-06 18:52 Doug Evans
2010-11-08 16:41 ` Joel Brobecker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101108164125.GC2933@adacore.com \
--to=brobecker@adacore.com \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox