From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 715 invoked by alias); 8 Nov 2010 16:41:37 -0000 Received: (qmail 603 invoked by uid 22791); 8 Nov 2010 16:41:36 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 08 Nov 2010 16:41:32 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 6F9172BAC63; Mon, 8 Nov 2010 11:41:30 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 313ik-YCcWYU; Mon, 8 Nov 2010 11:41:30 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 3E19A2BAC56; Mon, 8 Nov 2010 11:41:30 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 4F334145907; Mon, 8 Nov 2010 08:41:25 -0800 (PST) Date: Mon, 08 Nov 2010 16:41:00 -0000 From: Joel Brobecker To: Doug Evans Cc: gdb-patches@sourceware.org Subject: Re: [patch] value_change_enclosing_type -> set_value_enclosing_type Message-ID: <20101108164125.GC2933@adacore.com> References: <20101106185152.EE5612461A3@ruffy.mtv.corp.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20101106185152.EE5612461A3@ruffy.mtv.corp.google.com> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-11/txt/msg00119.txt.bz2 > This patch does two things: > - rename value_change_enclosing_type to set_value_enclosing_type, > and make the result void, for clarity and consistency with other > set_value_foo functions > - have value_full_object always return a new value if it needs to > modify the input value > > I will check it in in a few days if there are no objections. > > Tested on amd64-linux, no regressions. > > 2010-11-06 Doug Evans > > * value.c (set_value_enclosing_type): Renamed from > value_change_enclosing_type. All callers updated. > * value.h (set_value_enclosing_type): Update. > * valops.c (value_full_object): Always return a copy if we need to > make changes to the input value. FWIW, I like this change. -- Joel