From: Joel Brobecker <brobecker@adacore.com>
To: Nathan Froyd <froydnj@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] fix debugging code compiled for newer PPC BookE processors
Date: Tue, 02 Nov 2010 18:23:00 -0000 [thread overview]
Message-ID: <20101102182326.GD2492@adacore.com> (raw)
In-Reply-To: <1288380041-22165-1-git-send-email-froydnj@codesourcery.com>
> -Nathan
>
> * rs6000-tdep.c (bfd_uses_spe_extensions): New function.
> (rs6000_gdbarch_init): Call it.
This looks reasonable to me. Just one question, but please go ahead
and commit if you think the code is right.
> + /* The type must be 2. */
> + if (type != 2)
> + break;
So, the type must always be 2 and I am to understand that if type is not
2, then the data is screwed, hence the early exit? What's the purpose of
that field, if it is always the same value?
--
Joel
next prev parent reply other threads:[~2010-11-02 18:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-29 19:27 Nathan Froyd
2010-11-02 18:23 ` Joel Brobecker [this message]
2010-11-02 18:46 ` Nathan Froyd
2010-11-02 18:53 ` Joel Brobecker
2010-11-25 0:29 ` [commit] Build failure on ppc-aix (bfd_elf_get_obj_attr_int is undefined) Joel Brobecker
2010-11-29 22:06 ` Nathan Froyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101102182326.GD2492@adacore.com \
--to=brobecker@adacore.com \
--cc=froydnj@codesourcery.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox