From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22388 invoked by alias); 2 Nov 2010 18:23:40 -0000 Received: (qmail 22361 invoked by uid 22791); 2 Nov 2010 18:23:38 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 02 Nov 2010 18:23:33 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 638732BABE8; Tue, 2 Nov 2010 14:23:31 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id D4Vl9CQ3jqo3; Tue, 2 Nov 2010 14:23:31 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 1C7C82BABDC; Tue, 2 Nov 2010 14:23:30 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id B1C14F588F; Tue, 2 Nov 2010 11:23:26 -0700 (PDT) Date: Tue, 02 Nov 2010 18:23:00 -0000 From: Joel Brobecker To: Nathan Froyd Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] fix debugging code compiled for newer PPC BookE processors Message-ID: <20101102182326.GD2492@adacore.com> References: <1288380041-22165-1-git-send-email-froydnj@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1288380041-22165-1-git-send-email-froydnj@codesourcery.com> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-11/txt/msg00036.txt.bz2 > -Nathan > > * rs6000-tdep.c (bfd_uses_spe_extensions): New function. > (rs6000_gdbarch_init): Call it. This looks reasonable to me. Just one question, but please go ahead and commit if you think the code is right. > + /* The type must be 2. */ > + if (type != 2) > + break; So, the type must always be 2 and I am to understand that if type is not 2, then the data is screwed, hence the early exit? What's the purpose of that field, if it is always the same value? -- Joel