Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Nathan Froyd <froydnj@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] skip break-entry.exp when using a stub
Date: Tue, 02 Nov 2010 17:58:00 -0000	[thread overview]
Message-ID: <20101102175755.GA2492@adacore.com> (raw)
In-Reply-To: <1288380040-22077-1-git-send-email-froydnj@codesourcery.com>

> -Nathan
> 
> 	* gdb.base/break-entry.exp: Skip if using a stub.

I am not sure about one detail:

> +# If we're using a stub, we'll already be stopped at the entry point
> +# when we connect.  Don't bother trying to work around this in the
> +# testing below.
> +
> +if [target_info exists use_gdb_stub] {
> +    untested ${testfile}.exp
> +    return
> +}

I am not sure that the use of "untested" is correct, here. Looking
at the dejagnu documentation:

    UNTESTED
        A test was not run. This is a placeholder, used when there is no
        real test case yet. 

    untested "string"
        Declares a test was not run. untested writes in the log file
        a message beginning with `UNTESTED', appending the argument
        string. For example, you might use this in a dummy test whose
        only role is to record that a test does not yet exist for some
        feature. 

Perhaps we just ought to `return' directly. What do others think?

-- 
Joel


  parent reply	other threads:[~2010-11-02 17:58 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-29 19:20 Nathan Froyd
2010-10-29 20:10 ` Pedro Alves
2010-11-02 17:58 ` Joel Brobecker [this message]
2010-11-02 18:04   ` Michael Snyder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101102175755.GA2492@adacore.com \
    --to=brobecker@adacore.com \
    --cc=froydnj@codesourcery.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox