From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5279 invoked by alias); 2 Nov 2010 17:58:12 -0000 Received: (qmail 5260 invoked by uid 22791); 2 Nov 2010 17:58:09 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 02 Nov 2010 17:58:02 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 645322BAB61; Tue, 2 Nov 2010 13:58:00 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id H8mxYz6L-Lfi; Tue, 2 Nov 2010 13:58:00 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 1727D2BAB39; Tue, 2 Nov 2010 13:57:59 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id A3FE6F588F; Tue, 2 Nov 2010 10:57:55 -0700 (PDT) Date: Tue, 02 Nov 2010 17:58:00 -0000 From: Joel Brobecker To: Nathan Froyd Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] skip break-entry.exp when using a stub Message-ID: <20101102175755.GA2492@adacore.com> References: <1288380040-22077-1-git-send-email-froydnj@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1288380040-22077-1-git-send-email-froydnj@codesourcery.com> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-11/txt/msg00028.txt.bz2 > -Nathan > > * gdb.base/break-entry.exp: Skip if using a stub. I am not sure about one detail: > +# If we're using a stub, we'll already be stopped at the entry point > +# when we connect. Don't bother trying to work around this in the > +# testing below. > + > +if [target_info exists use_gdb_stub] { > + untested ${testfile}.exp > + return > +} I am not sure that the use of "untested" is correct, here. Looking at the dejagnu documentation: UNTESTED A test was not run. This is a placeholder, used when there is no real test case yet. untested "string" Declares a test was not run. untested writes in the log file a message beginning with `UNTESTED', appending the argument string. For example, you might use this in a dummy test whose only role is to record that a test does not yet exist for some feature. Perhaps we just ought to `return' directly. What do others think? -- Joel