Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Ulrich Weigand" <uweigand@de.ibm.com>
To: jan.kratochvil@redhat.com (Jan Kratochvil)
Cc: gdb-patches@sourceware.org
Subject: Re: [commit] Fix timeouts in break-interp.exp on slow machines
Date: Tue, 12 Oct 2010 18:37:00 -0000	[thread overview]
Message-ID: <201010121837.o9CIbHSN004504@d12av02.megacenter.de.ibm.com> (raw)
In-Reply-To: <20101012182337.GA15377@host1.dyn.jankratochvil.net> from "Jan Kratochvil" at Oct 12, 2010 08:23:37 PM

Jan Kratochvil wrote:
> On Tue, 12 Oct 2010 19:20:29 +0200, Ulrich Weigand wrote:
> > This is once again caused by a gdb_expect clause with a ".*" wildcard that
> > matches a large number of lines.  This can cause expect to slow down
> > significantly, to the extent that the tests time out on slow machines.
> 
> OK, thanks for the fix.  I do not have the slowness reproducible here but
> I thought gdb_expect is deprecated in the favor of gdb_test_multiple.
> 
> I do not mind but just curious if it could be rather coded this way or it
> would be still slow/incompatible by the more patterns of gdb_test_multiple?

Ah, I wasn't aware you could use gdb_test_multiple with an empty
string to send to GDB!  That's even better, of course.

> 2010-10-12  Jan Kratochvil  <jan.kratochvil@redhat.com>
> 
> 	* gdb.base/break-interp.exp (test_ld): Replace gdb_expect by
> 	gdb_test_multiple.

This still works for me (no timeouts) on armv7l-linux-gnueabi.

Thanks,
Ulrich

-- 
  Dr. Ulrich Weigand
  GNU Toolchain for Linux on System z and Cell BE
  Ulrich.Weigand@de.ibm.com


  reply	other threads:[~2010-10-12 18:37 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-12 17:20 Ulrich Weigand
2010-10-12 18:23 ` Jan Kratochvil
2010-10-12 18:37   ` Ulrich Weigand [this message]
2010-10-12 18:41     ` Jan Kratochvil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201010121837.o9CIbHSN004504@d12av02.megacenter.de.ibm.com \
    --to=uweigand@de.ibm.com \
    --cc=gdb-patches@sourceware.org \
    --cc=jan.kratochvil@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox