Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Matt Rice <ratmice@gmail.com>
Cc: Michael Snyder <msnyder@vmware.com>,
	       "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: disable objective-c stuff when theres no objective-c cu.
Date: Wed, 06 Oct 2010 08:51:00 -0000	[thread overview]
Message-ID: <20101006085132.GA11910@host1.dyn.jankratochvil.net> (raw)
In-Reply-To: <AANLkTikYV-ix6tkRWc7aZtbgdbegJeejA8+DB0OR3QFY@mail.gmail.com>

On Wed, 06 Oct 2010 04:30:33 +0200, Matt Rice wrote:
> that we can lessen the impact by checking for is_objc_method, or for
> objective-c compilation units. (is_objc_method doesn't neccesarily
> affect future lookups should it call set_language_has_cu_loaded?)

Wouldn't be enough to replace the bitmask just by?
	if (current_language->la_language == language_objc)


> here is when gcc started to emit DW_LANG_ObjC, maybe we could fall
> back to source files with the .m extension.
> http://gcc.gnu.org/ml/gcc-patches/2006-03/msg01515.html

For current_language it works even without DW_LANG_ObjC due to:
	init_filename_language_table (void)
	      add_filename_language (".m", language_objc);


> -PASS: gdb.cp/psmang.exp: break s::method2
> +FAIL: gdb.cp/psmang.exp: break s::method2 (got interactive prompt)

There is also a regression for:
	gdb.ada/frame_args.exp
	gdb.ada/ptype_tagged_param.exp
	gdb.ada/ref_param.exp


> -FAIL: gdb.threads/attachstop-mt.exp: attach1, post-gdb sanity check of the sleeping state - Red Hat BZ 197584
> +PASS: gdb.threads/attachstop-mt.exp: attach1, post-gdb sanity check of the sleeping state - Red Hat BZ 197584

This one is racy, I should fix it.


Thanks,
Jan


  reply	other threads:[~2010-10-06  8:51 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-05 22:37 Matt Rice
2010-10-05 23:31 ` Michael Snyder
2010-10-05 23:35   ` Matt Rice
2010-10-06  2:30     ` Matt Rice
2010-10-06  8:51       ` Jan Kratochvil [this message]
2010-10-06 10:03         ` Matt Rice
2010-10-06 13:12           ` Matt Rice
2010-10-06 17:06             ` Joel Brobecker
2010-10-06 17:54               ` Matt Rice
2010-10-17 20:13             ` Jan Kratochvil
2010-10-17 21:57               ` Matt Rice

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101006085132.GA11910@host1.dyn.jankratochvil.net \
    --to=jan.kratochvil@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=msnyder@vmware.com \
    --cc=ratmice@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox