From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24174 invoked by alias); 6 Oct 2010 08:51:44 -0000 Received: (qmail 24166 invoked by uid 22791); 6 Oct 2010 08:51:44 -0000 X-SWARE-Spam-Status: No, hits=-6.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 06 Oct 2010 08:51:38 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o968pbqI003692 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 6 Oct 2010 04:51:37 -0400 Received: from host1.dyn.jankratochvil.net (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id o968pYZC011819 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Wed, 6 Oct 2010 04:51:36 -0400 Received: from host1.dyn.jankratochvil.net (localhost [127.0.0.1]) by host1.dyn.jankratochvil.net (8.14.4/8.14.4) with ESMTP id o968pYpH011100; Wed, 6 Oct 2010 10:51:34 +0200 Received: (from jkratoch@localhost) by host1.dyn.jankratochvil.net (8.14.4/8.14.4/Submit) id o968pX7A011098; Wed, 6 Oct 2010 10:51:33 +0200 Date: Wed, 06 Oct 2010 08:51:00 -0000 From: Jan Kratochvil To: Matt Rice Cc: Michael Snyder , "gdb-patches@sourceware.org" Subject: Re: disable objective-c stuff when theres no objective-c cu. Message-ID: <20101006085132.GA11910@host1.dyn.jankratochvil.net> References: <4CABB53A.8000101@vmware.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-10/txt/msg00069.txt.bz2 On Wed, 06 Oct 2010 04:30:33 +0200, Matt Rice wrote: > that we can lessen the impact by checking for is_objc_method, or for > objective-c compilation units. (is_objc_method doesn't neccesarily > affect future lookups should it call set_language_has_cu_loaded?) Wouldn't be enough to replace the bitmask just by? if (current_language->la_language == language_objc) > here is when gcc started to emit DW_LANG_ObjC, maybe we could fall > back to source files with the .m extension. > http://gcc.gnu.org/ml/gcc-patches/2006-03/msg01515.html For current_language it works even without DW_LANG_ObjC due to: init_filename_language_table (void) add_filename_language (".m", language_objc); > -PASS: gdb.cp/psmang.exp: break s::method2 > +FAIL: gdb.cp/psmang.exp: break s::method2 (got interactive prompt) There is also a regression for: gdb.ada/frame_args.exp gdb.ada/ptype_tagged_param.exp gdb.ada/ref_param.exp > -FAIL: gdb.threads/attachstop-mt.exp: attach1, post-gdb sanity check of the sleeping state - Red Hat BZ 197584 > +PASS: gdb.threads/attachstop-mt.exp: attach1, post-gdb sanity check of the sleeping state - Red Hat BZ 197584 This one is racy, I should fix it. Thanks, Jan