From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org
Cc: Jan Kratochvil <jan.kratochvil@redhat.com>
Subject: Re: [patch] Fix printing parameters of inlined functions
Date: Tue, 28 Sep 2010 15:57:00 -0000 [thread overview]
Message-ID: <201009280940.45554.pedro@codesourcery.com> (raw)
In-Reply-To: <20100927232839.GA22548@host1.dyn.jankratochvil.net>
Looks good to me. One note:
On Tuesday 28 September 2010 00:28:39, Jan Kratochvil wrote:
> ui_out_text (uiout, " (");
> - if (print_args)
> + if (print_args && func != NULL)
I think this changes MI behaviour, but I didn't try it.
It looks like we will print no "args" list at all, while
before it would print an empty "args" list. No sure whether that's
a safe change.
> {
> struct print_args_args args;
> struct cleanup *args_list_chain;
>
> args.frame = frame;
> - args.func = find_pc_function (get_frame_address_in_block (frame));
> + args.func = func;
> args.stream = gdb_stdout;
> args_list_chain = make_cleanup_ui_out_list_begin_end (uiout, "args");
--
Pedro Alves
next prev parent reply other threads:[~2010-09-28 8:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-28 15:15 Jan Kratochvil
2010-09-28 15:57 ` Pedro Alves [this message]
2010-09-30 2:09 ` Jan Kratochvil
2010-09-30 14:41 ` Pedro Alves
2010-09-30 14:43 ` Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201009280940.45554.pedro@codesourcery.com \
--to=pedro@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox