From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18770 invoked by alias); 28 Sep 2010 08:40:55 -0000 Received: (qmail 18759 invoked by uid 22791); 28 Sep 2010 08:40:55 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 28 Sep 2010 08:40:50 +0000 Received: (qmail 19727 invoked from network); 28 Sep 2010 08:40:48 -0000 Received: from unknown (HELO orlando.localnet) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 28 Sep 2010 08:40:48 -0000 From: Pedro Alves To: gdb-patches@sourceware.org Subject: Re: [patch] Fix printing parameters of inlined functions Date: Tue, 28 Sep 2010 15:57:00 -0000 User-Agent: KMail/1.13.2 (Linux/2.6.33-29-realtime; KDE/4.4.2; x86_64; ; ) Cc: Jan Kratochvil References: <20100927232839.GA22548@host1.dyn.jankratochvil.net> In-Reply-To: <20100927232839.GA22548@host1.dyn.jankratochvil.net> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201009280940.45554.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-09/txt/msg00468.txt.bz2 Looks good to me. One note: On Tuesday 28 September 2010 00:28:39, Jan Kratochvil wrote: > ui_out_text (uiout, " ("); > - if (print_args) > + if (print_args && func != NULL) I think this changes MI behaviour, but I didn't try it. It looks like we will print no "args" list at all, while before it would print an empty "args" list. No sure whether that's a safe change. > { > struct print_args_args args; > struct cleanup *args_list_chain; > > args.frame = frame; > - args.func = find_pc_function (get_frame_address_in_block (frame)); > + args.func = func; > args.stream = gdb_stdout; > args_list_chain = make_cleanup_ui_out_list_begin_end (uiout, "args"); -- Pedro Alves