Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Ulrich Weigand" <uweigand@de.ibm.com>
To: dan@codesourcery.com (Daniel Jacobowitz)
Cc: gdb-patches@sourceware.org, rearnsha@arm.com
Subject: Re: [rfa] Fix software-watchpoint failures by adding epilogue detection
Date: Thu, 23 Sep 2010 16:13:00 -0000	[thread overview]
Message-ID: <201009231300.o8ND0YqF028161@d12av02.megacenter.de.ibm.com> (raw)
In-Reply-To: <20100922193753.GA25020@caradoc.them.org> from "Daniel Jacobowitz" at Sep 22, 2010 03:37:59 PM

Dan Jacobowitz wrote:

> One of the patches we haven't had a chance to submit took the same
> approach to solve these failures.  I also did ARM mode, as well as
> some additional sequences - probably those used by RealView.  I've
> attached it.

Thanks!  Unfortunately it doesn't fix the problem with our current
ARM compiler, because your heuristics doesn't recognize the sequence
we get as epilogue:

    83c8:       f107 0710       add.w   r7, r7, #16
    83cc:       46bd            mov     sp, r7
    83ce:       bd80            pop     {r7, pc}

On the other hand, your patch does indeed accept a couple of additonal
instructions compared to mine.  I'll come up with a merged approach ...

> We have at least one other patch related to ARM testsuite failures,
> specifically an ERROR (probably infinite backtrace) in gdb1250.exp.
> I can extract it for you if you'd like, but I'm not sure it's in
> condition to be merged.

Hmm, this test is passing now.  We did have problems with backtraces
out of abort, but this was due to a compiler problem -- it simply
would not save the return address at all for no-return functions.
This is now fixed in the compiler ...

Bye,
Ulrich

-- 
  Dr. Ulrich Weigand
  GNU Toolchain for Linux on System z and Cell BE
  Ulrich.Weigand@de.ibm.com


  reply	other threads:[~2010-09-23 13:00 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-22 19:20 Ulrich Weigand
2010-09-22 20:01 ` Daniel Jacobowitz
2010-09-23 16:13   ` Ulrich Weigand [this message]
2010-09-24 16:11     ` Ulrich Weigand
2010-09-28 20:23       ` Daniel Jacobowitz
2010-09-28 21:47         ` Ulrich Weigand
2010-09-28 21:49           ` Daniel Jacobowitz
2010-09-29 15:24             ` Richard Earnshaw
2010-10-07 16:12             ` [rfa, v3] Fix software-watchpoint failures on ARM " Ulrich Weigand
2010-10-08 13:01               ` Richard Earnshaw
2010-10-08 13:27                 ` Ulrich Weigand
2010-09-29 14:43           ` [rfa] Fix software-watchpoint failures " Yao Qi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201009231300.o8ND0YqF028161@d12av02.megacenter.de.ibm.com \
    --to=uweigand@de.ibm.com \
    --cc=dan@codesourcery.com \
    --cc=gdb-patches@sourceware.org \
    --cc=rearnsha@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox