Re: [PING]RE: [RFA] Fix maint translate command

[Joel Brobecker <brobecker@adacore.com>]

On Tue, Sep 14, 2010 at 10:10:02AM +0200, Pierre Muller wrote:
>    The problem of break inside ALL_OBJSECTIONS
> is still not fixed on CVS despite a fix proposed by Pedro?
> 
>   I must confess that I am unable to fully understand such complicated
> macros, and I leave to others the responsibility to
> approve such kind of patches (I don't have any rights on
> objfiles sources anyhow ...)
> 
>   Would it be possible to check Pedro's patch in?

Seems like everyone is really really busy these days :-(.
This is coming from Pedro, and I didn't see anything wrong with it.
Since we haven't received any objection, I think it is fine to commit
after running it against the testsuite.

> > > I admit it loop ugly, and that may look complicated, but it isn't
> > > (complicated).  The outer loop learns about the inner loop's end
> > > condition, and stops iterating if it detects the inner loop didn't
> > > reach it's end.  The trick to not clearing "objfile" is to only
> > > advance it in the outer loop, if the inner loop reached it's end.

I think that this is a useful comment to add to the macro.  And perhaps
explain that the purpose is to allow `break' to exit the ALL_OBJSECTIONS
(double-) loop.

-- 
Joel