From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14319 invoked by alias); 22 Sep 2010 17:01:24 -0000 Received: (qmail 14308 invoked by uid 22791); 22 Sep 2010 17:01:22 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,TW_BJ X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 22 Sep 2010 17:01:16 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 43D802BAB9C; Wed, 22 Sep 2010 13:01:14 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id sEERbpNGQI8r; Wed, 22 Sep 2010 13:01:14 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id D7F142BAB8A; Wed, 22 Sep 2010 13:01:13 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 28CC6F591E; Wed, 22 Sep 2010 10:01:11 -0700 (PDT) Date: Wed, 22 Sep 2010 18:59:00 -0000 From: Joel Brobecker To: Pierre Muller Cc: 'Pedro Alves' , gdb-patches@sourceware.org Subject: Re: [PING]RE: [RFA] Fix maint translate command Message-ID: <20100922170111.GE3063@adacore.com> References: <002101cb49b3$50d60cd0$f2822670$@muller@ics-cnrs.unistra.fr> <000001cb49dc$81074080$8315c180$@muller@ics-cnrs.unistra.fr> <201009011625.27952.pedro@codesourcery.com> <201009011707.14802.pedro@codesourcery.com> <001201cb53e4$3c294e60$b47beb20$@muller@ics-cnrs.unistra.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <001201cb53e4$3c294e60$b47beb20$@muller@ics-cnrs.unistra.fr> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-09/txt/msg00377.txt.bz2 On Tue, Sep 14, 2010 at 10:10:02AM +0200, Pierre Muller wrote: > The problem of break inside ALL_OBJSECTIONS > is still not fixed on CVS despite a fix proposed by Pedro? > > I must confess that I am unable to fully understand such complicated > macros, and I leave to others the responsibility to > approve such kind of patches (I don't have any rights on > objfiles sources anyhow ...) > > Would it be possible to check Pedro's patch in? Seems like everyone is really really busy these days :-(. This is coming from Pedro, and I didn't see anything wrong with it. Since we haven't received any objection, I think it is fine to commit after running it against the testsuite. > > > I admit it loop ugly, and that may look complicated, but it isn't > > > (complicated). The outer loop learns about the inner loop's end > > > condition, and stops iterating if it detects the inner loop didn't > > > reach it's end. The trick to not clearing "objfile" is to only > > > advance it in the outer loop, if the inner loop reached it's end. I think that this is a useful comment to add to the macro. And perhaps explain that the purpose is to allow `break' to exit the ALL_OBJSECTIONS (double-) loop. -- Joel