* PATCH: Remove amd64_register_name
@ 2010-09-12 13:31 H.J. Lu
2010-09-12 21:51 ` Mark Kettenis
0 siblings, 1 reply; 2+ messages in thread
From: H.J. Lu @ 2010-09-12 13:31 UTC (permalink / raw)
To: GDB
Hi,
amd64_register_name is the same as i386_register_name. There is no
need for it. This patch removes it. Tested on Linux/x86-64 and
Linux/x86-64 with AVX. OK to install?
Thanks.
H.J.
---
2010-09-11 H.J. Lu <hongjiu.lu@intel.com>
* amd64-tdep.c (amd64_register_name): Removed.
(amd64_init_abi): Don't call set_gdbarch_register_name.
* i386-tdep.c (i386_ymmh_regnum_p): Make it static.
* i386-tdep.h (i386_ymmh_regnum_p): Removed.
diff --git a/gdb/amd64-tdep.c b/gdb/amd64-tdep.c
index 9feed90..5472db1 100644
--- a/gdb/amd64-tdep.c
+++ b/gdb/amd64-tdep.c
@@ -257,19 +257,6 @@ static const char *amd64_dword_names[] =
"r8d", "r9d", "r10d", "r11d", "r12d", "r13d", "r14d", "r15d"
};
-/* Return the name of register REGNUM, or the empty string if it is
- an anonymous register. */
-
-static const char *
-amd64_register_name (struct gdbarch *gdbarch, int regnum)
-{
- /* Hide the upper YMM registers. */
- if (i386_ymmh_regnum_p (gdbarch, regnum))
- return "";
-
- return tdesc_register_name (gdbarch, regnum);
-}
-
/* Return the name of register REGNUM. */
static const char *
@@ -2407,8 +2394,6 @@ amd64_init_abi (struct gdbarch_info info, struct gdbarch *gdbarch)
set_tdesc_pseudo_register_name (gdbarch, amd64_pseudo_register_name);
- set_gdbarch_register_name (gdbarch, amd64_register_name);
-
/* AMD64 has an FPU and 16 SSE registers. */
tdep->st0_regnum = AMD64_ST0_REGNUM;
tdep->num_xmm_regs = 16;
diff --git a/gdb/i386-tdep.c b/gdb/i386-tdep.c
index 435b623..ea282a7 100644
--- a/gdb/i386-tdep.c
+++ b/gdb/i386-tdep.c
@@ -165,7 +165,7 @@ i386_dword_regnum_p (struct gdbarch *gdbarch, int regnum)
return regnum >= 0 && regnum < tdep->num_dword_regs;
}
-int
+static int
i386_ymmh_regnum_p (struct gdbarch *gdbarch, int regnum)
{
struct gdbarch_tdep *tdep = gdbarch_tdep (gdbarch);
diff --git a/gdb/i386-tdep.h b/gdb/i386-tdep.h
index 49e0727..4d0bae7 100644
--- a/gdb/i386-tdep.h
+++ b/gdb/i386-tdep.h
@@ -307,7 +307,6 @@ extern int i386_word_regnum_p (struct gdbarch *gdbarch, int regnum);
extern int i386_dword_regnum_p (struct gdbarch *gdbarch, int regnum);
extern int i386_xmm_regnum_p (struct gdbarch *gdbarch, int regnum);
extern int i386_ymm_regnum_p (struct gdbarch *gdbarch, int regnum);
-extern int i386_ymmh_regnum_p (struct gdbarch *gdbarch, int regnum);
extern const char *i386_pseudo_register_name (struct gdbarch *gdbarch,
int regnum);
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: PATCH: Remove amd64_register_name
2010-09-12 13:31 PATCH: Remove amd64_register_name H.J. Lu
@ 2010-09-12 21:51 ` Mark Kettenis
0 siblings, 0 replies; 2+ messages in thread
From: Mark Kettenis @ 2010-09-12 21:51 UTC (permalink / raw)
To: hjl.tools; +Cc: gdb-patches
> Date: Sat, 11 Sep 2010 09:34:14 -0700
> From: "H.J. Lu" <hongjiu.lu@intel.com>
>
> Hi,
>
> amd64_register_name is the same as i386_register_name. There is no
> need for it. This patch removes it. Tested on Linux/x86-64 and
> Linux/x86-64 with AVX. OK to install?
Yes
> ---
> 2010-09-11 H.J. Lu <hongjiu.lu@intel.com>
>
> * amd64-tdep.c (amd64_register_name): Removed.
> (amd64_init_abi): Don't call set_gdbarch_register_name.
>
> * i386-tdep.c (i386_ymmh_regnum_p): Make it static.
>
> * i386-tdep.h (i386_ymmh_regnum_p): Removed.
>
> diff --git a/gdb/amd64-tdep.c b/gdb/amd64-tdep.c
> index 9feed90..5472db1 100644
> --- a/gdb/amd64-tdep.c
> +++ b/gdb/amd64-tdep.c
> @@ -257,19 +257,6 @@ static const char *amd64_dword_names[] =
> "r8d", "r9d", "r10d", "r11d", "r12d", "r13d", "r14d", "r15d"
> };
>
> -/* Return the name of register REGNUM, or the empty string if it is
> - an anonymous register. */
> -
> -static const char *
> -amd64_register_name (struct gdbarch *gdbarch, int regnum)
> -{
> - /* Hide the upper YMM registers. */
> - if (i386_ymmh_regnum_p (gdbarch, regnum))
> - return "";
> -
> - return tdesc_register_name (gdbarch, regnum);
> -}
> -
> /* Return the name of register REGNUM. */
>
> static const char *
> @@ -2407,8 +2394,6 @@ amd64_init_abi (struct gdbarch_info info, struct gdbarch *gdbarch)
>
> set_tdesc_pseudo_register_name (gdbarch, amd64_pseudo_register_name);
>
> - set_gdbarch_register_name (gdbarch, amd64_register_name);
> -
> /* AMD64 has an FPU and 16 SSE registers. */
> tdep->st0_regnum = AMD64_ST0_REGNUM;
> tdep->num_xmm_regs = 16;
> diff --git a/gdb/i386-tdep.c b/gdb/i386-tdep.c
> index 435b623..ea282a7 100644
> --- a/gdb/i386-tdep.c
> +++ b/gdb/i386-tdep.c
> @@ -165,7 +165,7 @@ i386_dword_regnum_p (struct gdbarch *gdbarch, int regnum)
> return regnum >= 0 && regnum < tdep->num_dword_regs;
> }
>
> -int
> +static int
> i386_ymmh_regnum_p (struct gdbarch *gdbarch, int regnum)
> {
> struct gdbarch_tdep *tdep = gdbarch_tdep (gdbarch);
> diff --git a/gdb/i386-tdep.h b/gdb/i386-tdep.h
> index 49e0727..4d0bae7 100644
> --- a/gdb/i386-tdep.h
> +++ b/gdb/i386-tdep.h
> @@ -307,7 +307,6 @@ extern int i386_word_regnum_p (struct gdbarch *gdbarch, int regnum);
> extern int i386_dword_regnum_p (struct gdbarch *gdbarch, int regnum);
> extern int i386_xmm_regnum_p (struct gdbarch *gdbarch, int regnum);
> extern int i386_ymm_regnum_p (struct gdbarch *gdbarch, int regnum);
> -extern int i386_ymmh_regnum_p (struct gdbarch *gdbarch, int regnum);
>
> extern const char *i386_pseudo_register_name (struct gdbarch *gdbarch,
> int regnum);
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-09-11 18:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-09-12 13:31 PATCH: Remove amd64_register_name H.J. Lu
2010-09-12 21:51 ` Mark Kettenis
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox