Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch 3/9]#2 Change target_signal_t to a struct
Date: Wed, 01 Sep 2010 18:40:00 -0000	[thread overview]
Message-ID: <20100901183941.GA24300@host1.dyn.jankratochvil.net> (raw)
In-Reply-To: <20100901182558.GA2422@adacore.com>

On Wed, 01 Sep 2010 20:25:58 +0200, Joel Brobecker wrote:
> I don't know what people think, but I'd rather have an opaque structure
> in this case.

I do not understand now.  The struct must be defined, not just declared.
GDB sources use variables of its type, not just pointers to it.


> How about defining this struct in common/gdb_signals.h and then the
> accessors in common/signals.c?

Or do you just mean to move
	TARGET_SIGNAL_NUMBER
	target_signal_from_number
	TARGET_SIGNAL_EQ
	TARGET_SIGNAL_NE
	TARGET_SIGNAL_LT
	TARGET_SIGNAL_GT
	TARGET_SIGNAL_LE
	TARGET_SIGNAL_GE
from common/gdb_signals.h to common/signals.c and remove
	TARGET_SIGNAL_INITIALIZER
?

I can do that, LTO should even make it efficient the same.


Thanks,
Jan


  reply	other threads:[~2010-09-01 18:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-30  7:12 Jan Kratochvil
2010-09-01 18:26 ` Joel Brobecker
2010-09-01 18:40   ` Jan Kratochvil [this message]
2010-09-01 18:50     ` Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100901183941.GA24300@host1.dyn.jankratochvil.net \
    --to=jan.kratochvil@redhat.com \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox