From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 713 invoked by alias); 1 Sep 2010 18:40:05 -0000 Received: (qmail 705 invoked by uid 22791); 1 Sep 2010 18:40:04 -0000 X-SWARE-Spam-Status: No, hits=-6.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 01 Sep 2010 18:40:00 +0000 Received: from int-mx03.intmail.prod.int.phx2.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o81IdiPF015609 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 1 Sep 2010 14:39:44 -0400 Received: from host1.dyn.jankratochvil.net (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx03.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o81IdgTd011947 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 1 Sep 2010 14:39:44 -0400 Received: from host1.dyn.jankratochvil.net (localhost [127.0.0.1]) by host1.dyn.jankratochvil.net (8.14.4/8.14.4) with ESMTP id o81Idg9J024559; Wed, 1 Sep 2010 20:39:42 +0200 Received: (from jkratoch@localhost) by host1.dyn.jankratochvil.net (8.14.4/8.14.4/Submit) id o81Idff3024558; Wed, 1 Sep 2010 20:39:41 +0200 Date: Wed, 01 Sep 2010 18:40:00 -0000 From: Jan Kratochvil To: Joel Brobecker Cc: gdb-patches@sourceware.org Subject: Re: [patch 3/9]#2 Change target_signal_t to a struct Message-ID: <20100901183941.GA24300@host1.dyn.jankratochvil.net> References: <20100830071150.GD6831@host1.dyn.jankratochvil.net> <20100901182558.GA2422@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100901182558.GA2422@adacore.com> User-Agent: Mutt/1.5.20 (2009-12-10) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-09/txt/msg00041.txt.bz2 On Wed, 01 Sep 2010 20:25:58 +0200, Joel Brobecker wrote: > I don't know what people think, but I'd rather have an opaque structure > in this case. I do not understand now. The struct must be defined, not just declared. GDB sources use variables of its type, not just pointers to it. > How about defining this struct in common/gdb_signals.h and then the > accessors in common/signals.c? Or do you just mean to move TARGET_SIGNAL_NUMBER target_signal_from_number TARGET_SIGNAL_EQ TARGET_SIGNAL_NE TARGET_SIGNAL_LT TARGET_SIGNAL_GT TARGET_SIGNAL_LE TARGET_SIGNAL_GE from common/gdb_signals.h to common/signals.c and remove TARGET_SIGNAL_INITIALIZER ? I can do that, LTO should even make it efficient the same. Thanks, Jan