From: Joel Brobecker <brobecker@adacore.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] Code cleanup: Make function typedef for find memory region
Date: Tue, 31 Aug 2010 17:33:00 -0000 [thread overview]
Message-ID: <20100831173328.GM2986@adacore.com> (raw)
In-Reply-To: <20100830085953.GA25961@host1.dyn.jankratochvil.net>
> gdb/
> 2010-08-30 Jan Kratochvil <jan.kratochvil@redhat.com>
>
> Code cleanup.
> * defs.h (find_memory_region_t): New typedef.
> (exec_set_find_memory_regions): Use it.
> * exec.c (exec_set_find_memory_regions): Use find_memory_region_t.
> * fbsd-nat.c (fbsd_find_memory_regions): Likewise.
> * gcore.c (objfile_find_memory_regions): Likewise.
> * gnu-nat.c (gnu_find_memory_regions): Likewise.
> * linux-nat.c (linux_nat_find_memory_regions): Likewise.
> * procfs.c (iterate_over_mappings_cb_ftype): Remove.
> (iterate_over_mappings): Rename iterate_over_mappings_cb_ftype to
> find_memory_region_t.
> (insert_dbx_link_bpt_in_region): Likewise.
> (iterate_over_mappings): Likewise. Drop the comment part about the
> function prototype.
> (find_memory_regions_callback): Use find_memory_region_t.
> (proc_find_memory_regions): Likewise.
> (info_mappings_callback): Rename iterate_over_mappings_cb_ftype to
> find_memory_region_t.
> * target.c (dummy_find_memory_regions): Use find_memory_region_t.
> * target.h (struct target_ops) <to_find_memory_regions>: Likewise.
Given the various comments so far, this patch is OK with the type
renamed to find_memory_region_ftype.
--
Joel
next prev parent reply other threads:[~2010-08-31 17:33 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-30 9:00 Jan Kratochvil
2010-08-30 10:44 ` Pedro Alves
2010-08-30 14:10 ` Joel Brobecker
2010-08-31 17:27 ` Jan Kratochvil
2010-08-31 18:12 ` Pedro Alves
2010-08-30 14:15 ` Joel Brobecker
2010-08-30 14:25 ` Jan Kratochvil
2010-08-30 14:58 ` Joel Brobecker
2010-08-30 15:04 ` Jan Kratochvil
2010-08-30 18:38 ` Tom Tromey
2010-08-31 13:02 ` Jan Kratochvil
2010-08-31 16:51 ` Tom Tromey
2010-08-31 17:13 ` Joel Brobecker
2010-08-31 17:33 ` Joel Brobecker [this message]
2010-08-31 18:09 ` Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100831173328.GM2986@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox