From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6189 invoked by alias); 31 Aug 2010 17:33:45 -0000 Received: (qmail 6181 invoked by uid 22791); 31 Aug 2010 17:33:45 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 31 Aug 2010 17:33:38 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id D43952BAB3C; Tue, 31 Aug 2010 13:33:36 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id xWYnSKqXOHVj; Tue, 31 Aug 2010 13:33:36 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id A14F42BAB06; Tue, 31 Aug 2010 13:33:36 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id F3212F599F; Tue, 31 Aug 2010 19:33:28 +0200 (CEST) Date: Tue, 31 Aug 2010 17:33:00 -0000 From: Joel Brobecker To: Jan Kratochvil Cc: gdb-patches@sourceware.org Subject: Re: [patch] Code cleanup: Make function typedef for find memory region Message-ID: <20100831173328.GM2986@adacore.com> References: <20100830085953.GA25961@host1.dyn.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100830085953.GA25961@host1.dyn.jankratochvil.net> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-08/txt/msg00556.txt.bz2 > gdb/ > 2010-08-30 Jan Kratochvil > > Code cleanup. > * defs.h (find_memory_region_t): New typedef. > (exec_set_find_memory_regions): Use it. > * exec.c (exec_set_find_memory_regions): Use find_memory_region_t. > * fbsd-nat.c (fbsd_find_memory_regions): Likewise. > * gcore.c (objfile_find_memory_regions): Likewise. > * gnu-nat.c (gnu_find_memory_regions): Likewise. > * linux-nat.c (linux_nat_find_memory_regions): Likewise. > * procfs.c (iterate_over_mappings_cb_ftype): Remove. > (iterate_over_mappings): Rename iterate_over_mappings_cb_ftype to > find_memory_region_t. > (insert_dbx_link_bpt_in_region): Likewise. > (iterate_over_mappings): Likewise. Drop the comment part about the > function prototype. > (find_memory_regions_callback): Use find_memory_region_t. > (proc_find_memory_regions): Likewise. > (info_mappings_callback): Rename iterate_over_mappings_cb_ftype to > find_memory_region_t. > * target.c (dummy_find_memory_regions): Use find_memory_region_t. > * target.h (struct target_ops) : Likewise. Given the various comments so far, this patch is OK with the type renamed to find_memory_region_ftype. -- Joel