From: Joel Brobecker <brobecker@adacore.com>
To: Doug Evans <dje@google.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] new macro: gdb_assert_not_reached
Date: Tue, 17 Aug 2010 07:17:00 -0000 [thread overview]
Message-ID: <20100817071653.GA3599@adacore.com> (raw)
In-Reply-To: <20100817000113.6467684B8F@ruffy.mtv.corp.google.com>
> This patch adds new macro gdb_assert_not_reached, and replaces
> all existing uses of gdb_assert (0) with the new macro.
FWIW, this looks good to me. I was a little surprised by the use
of a message parameter, but I think it's nice too (rather than
always reporting a bland `Unreachable code assertion failed').
--
Joel
prev parent reply other threads:[~2010-08-17 7:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-17 0:01 Doug Evans
2010-08-17 7:17 ` Joel Brobecker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100817071653.GA3599@adacore.com \
--to=brobecker@adacore.com \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox