From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6910 invoked by alias); 17 Aug 2010 07:17:02 -0000 Received: (qmail 6897 invoked by uid 22791); 17 Aug 2010 07:17:01 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 17 Aug 2010 07:16:56 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 07E082BAB95; Tue, 17 Aug 2010 03:16:55 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id FjK34b1HkP9l; Tue, 17 Aug 2010 03:16:54 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id D081A2BAB5A; Tue, 17 Aug 2010 03:16:54 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 36289F58F9; Tue, 17 Aug 2010 00:16:53 -0700 (PDT) Date: Tue, 17 Aug 2010 07:17:00 -0000 From: Joel Brobecker To: Doug Evans Cc: gdb-patches@sourceware.org Subject: Re: [patch] new macro: gdb_assert_not_reached Message-ID: <20100817071653.GA3599@adacore.com> References: <20100817000113.6467684B8F@ruffy.mtv.corp.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100817000113.6467684B8F@ruffy.mtv.corp.google.com> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-08/txt/msg00253.txt.bz2 > This patch adds new macro gdb_assert_not_reached, and replaces > all existing uses of gdb_assert (0) with the new macro. FWIW, this looks good to me. I was a little surprised by the use of a message parameter, but I think it's nice too (rather than always reporting a bland `Unreachable code assertion failed'). -- Joel