Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Ken Werner <ken@linux.vnet.ibm.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] GNU vector binop support
Date: Tue, 10 Aug 2010 23:34:00 -0000	[thread overview]
Message-ID: <20100810233412.GA12832@host1.dyn.jankratochvil.net> (raw)
In-Reply-To: <201008101401.39991.ken@linux.vnet.ibm.com>

On Tue, 10 Aug 2010 14:01:39 +0200, Ken Werner wrote:
> +struct value *
> +vector_binop (struct value *val1, struct value *val2, enum exp_opcode op)
> +{
[...]
> +  elsize =  TYPE_LENGTH (eltype1);
> +  n = TYPE_LENGTH (type1) / elsize;
> +  val = allocate_value (type1);
> +
> +  mark = value_mark ();
> +  for (i = 0; i < n; i++)
> +    {
> +      tmp = value_binop (value_subscript (val1, i),
> +			 value_subscript (val2, i), op);

There is no check whether VAL1 and VAL2 are vectors of the same length (such
as the number of elements, even if the element size is the same).


Thanks,
Jan


      parent reply	other threads:[~2010-08-10 23:34 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-10  9:25 Ken Werner
2010-08-10 12:02 ` Ken Werner
2010-08-10 19:06   ` Tom Tromey
2010-08-11 11:41     ` Ken Werner
2010-08-11 16:06       ` Tom Tromey
2010-08-11 17:08         ` Ken Werner
2010-08-10 23:34   ` Jan Kratochvil [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100810233412.GA12832@host1.dyn.jankratochvil.net \
    --to=jan.kratochvil@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=ken@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox