From: Daniel Jacobowitz <dan@codesourcery.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFC 1/6] Rename `enum target_signal' to target_signal_t
Date: Tue, 27 Jul 2010 13:20:00 -0000 [thread overview]
Message-ID: <20100727132013.GA3747@caradoc.them.org> (raw)
In-Reply-To: <20100726225108.GB3597@host1.dyn.jankratochvil.net>
On Tue, Jul 27, 2010 at 12:51:08AM +0200, Jan Kratochvil wrote:
> I would fill-in the gdb/ ChangeLog if the patch'es idea does not get rejected.
> I understand the order is not right. Writing the ChangeLog will be a very
> costly task that could get dropped in several seconds of a first review.
Not much is wrong with the changelog you've got. I'd even do:
* gdb/signals.h (target_signal_t): New typedef, from enum
target_signal. All uses updated.
Or:
* gdb/signals.h (target_signal_t): New typedef, from enum
target_signal.
* aix-thread.c, amd64-linux-tdep.c, [all other files]: All uses
updated.
Doing anything more than that is IMO unnecessary.
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2010-07-27 13:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-26 22:51 Jan Kratochvil
2010-07-27 13:20 ` Daniel Jacobowitz [this message]
2010-08-30 7:20 ` obsoleted: " Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100727132013.GA3747@caradoc.them.org \
--to=dan@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox