From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5143 invoked by alias); 27 Jul 2010 13:20:27 -0000 Received: (qmail 5132 invoked by uid 22791); 27 Jul 2010 13:20:26 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 27 Jul 2010 13:20:22 +0000 Received: (qmail 26059 invoked from network); 27 Jul 2010 13:20:20 -0000 Received: from unknown (HELO caradoc.them.org) (dan@127.0.0.2) by mail.codesourcery.com with ESMTPA; 27 Jul 2010 13:20:20 -0000 Date: Tue, 27 Jul 2010 13:20:00 -0000 From: Daniel Jacobowitz To: Jan Kratochvil Cc: gdb-patches@sourceware.org Subject: Re: [RFC 1/6] Rename `enum target_signal' to target_signal_t Message-ID: <20100727132013.GA3747@caradoc.them.org> Mail-Followup-To: Jan Kratochvil , gdb-patches@sourceware.org References: <20100726225108.GB3597@host1.dyn.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100726225108.GB3597@host1.dyn.jankratochvil.net> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-07/txt/msg00419.txt.bz2 On Tue, Jul 27, 2010 at 12:51:08AM +0200, Jan Kratochvil wrote: > I would fill-in the gdb/ ChangeLog if the patch'es idea does not get rejected. > I understand the order is not right. Writing the ChangeLog will be a very > costly task that could get dropped in several seconds of a first review. Not much is wrong with the changelog you've got. I'd even do: * gdb/signals.h (target_signal_t): New typedef, from enum target_signal. All uses updated. Or: * gdb/signals.h (target_signal_t): New typedef, from enum target_signal. * aix-thread.c, amd64-linux-tdep.c, [all other files]: All uses updated. Doing anything more than that is IMO unnecessary. -- Daniel Jacobowitz CodeSourcery