From: Jerome Guitton <guitton@adacore.com>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA] Nullified garbage-collected global variables
Date: Mon, 26 Jul 2010 09:33:00 -0000 [thread overview]
Message-ID: <20100726093234.GR14704@adacore.com> (raw)
In-Reply-To: <m3ocdx24qg.fsf@fleche.redhat.com>
Tom Tromey (tromey@redhat.com):
> Jerome> * dwarf2read.c (add_partial_symbol): Do not add a global variable if
> Jerome> its adress is null. Add comment to explain why.
> Jerome> (new_symbol): Ditto.
>
> Looks ok to me.
This has now been committed.
> FWIW -- I prefer it if a fix and its corresponding test case are
> submitted and committed as a unit. I think it is more logical, and also
> the test case sometimes helps the review of the patch.
That makes perfect sense. I will do that in the future.
Thank you
Jerome
prev parent reply other threads:[~2010-07-26 9:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-12 15:22 Jerome Guitton
2010-07-13 16:28 ` Tom Tromey
2010-07-15 9:22 ` Jerome Guitton
2010-07-20 15:44 ` Jerome Guitton
2010-07-20 15:42 ` Jerome Guitton
2010-07-20 18:46 ` Tom Tromey
2010-07-21 13:30 ` Jerome Guitton
2010-07-23 22:50 ` Tom Tromey
2010-07-26 9:33 ` Jerome Guitton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100726093234.GR14704@adacore.com \
--to=guitton@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox