From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-74499-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 3535 invoked by alias); 26 Jul 2010 09:33:18 -0000
Received: (qmail 3522 invoked by uid 22791); 26 Jul 2010 09:33:17 -0000
X-SWARE-Spam-Status: No, hits=-1.1 required=5.0	tests=AWL,BAYES_20
X-Spam-Check-By: sourceware.org
Received: from mel.act-europe.fr (HELO mel.act-europe.fr) (212.99.106.210)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 26 Jul 2010 09:32:41 +0000
Received: from localhost (localhost [127.0.0.1])	by filtered-smtp.eu.adacore.com (Postfix) with ESMTP id C9FDBCB01E2;	Mon, 26 Jul 2010 11:32:35 +0200 (CEST)
Received: from mel.act-europe.fr ([127.0.0.1])	by localhost (smtp.eu.adacore.com [127.0.0.1]) (amavisd-new, port 10024)	with ESMTP id QFs+Pe8-Ric7; Mon, 26 Jul 2010 11:32:35 +0200 (CEST)
Received: from province.act-europe.fr (province.act-europe.fr [10.10.0.214])	by mel.act-europe.fr (Postfix) with ESMTP id B89A6CB01D3;	Mon, 26 Jul 2010 11:32:35 +0200 (CEST)
Received: by province.act-europe.fr (Postfix, from userid 560)	id 1D6251648B2; Mon, 26 Jul 2010 11:32:34 +0200 (CEST)
Date: Mon, 26 Jul 2010 09:33:00 -0000
From: Jerome Guitton <guitton@adacore.com>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA] Nullified garbage-collected global variables
Message-ID: <20100726093234.GR14704@adacore.com>
References: <1278948088-15391-1-git-send-email-guitton@adacore.com> <m3y6dftkhr.fsf@fleche.redhat.com> <20100720154223.GA80443@adacore.com> <m3aapmat60.fsf@fleche.redhat.com> <20100721133019.GA51363@adacore.com> <m3ocdx24qg.fsf@fleche.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <m3ocdx24qg.fsf@fleche.redhat.com>
User-Agent: Mutt/1.5.17 (2007-11-01)
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-07/txt/msg00390.txt.bz2

Tom Tromey (tromey@redhat.com):

> Jerome> 	* dwarf2read.c (add_partial_symbol): Do not add a global variable if
> Jerome> 	its adress is null. Add comment to explain why.
> Jerome> 	(new_symbol): Ditto.
> 
> Looks ok to me.

This has now been committed.


> FWIW -- I prefer it if a fix and its corresponding test case are
> submitted and committed as a unit.  I think it is more logical, and also
> the test case sometimes helps the review of the patch.

That makes perfect sense. I will do that in the future.

Thank you
Jerome