From: Joel Brobecker <brobecker@adacore.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: ping: [patch 5/6] testsuite: Fix prelink-support.exp without prelink installed
Date: Mon, 05 Jul 2010 17:40:00 -0000 [thread overview]
Message-ID: <20100705174015.GC2595@adacore.com> (raw)
In-Reply-To: <20100704101842.GE6875@host0.dyn.jankratochvil.net>
> GDB testsuite does not force English, neither dejagnu. But TCL seems to
> ignore locale:
That's more than good enough for me. Thanks!
> There is explicitly executed /usr/sbin/prelink because on some systems
> /usr/sbin is not in the default non-root $PATH. This also fixes:
Good point.
> Do you suggest /usr/sbin/prelink existence check, $PATH search (with
> explicitly appended `/usr/sbin') or the current error message check?
I think it's fine to wait until we actually find a system where the
current approach is not working. So:
> gdb/testsuite/
> 2010-07-04 Jan Kratochvil <jan.kratochvil@redhat.com>
> Joel Brobecker <brobecker@adacore.com>
>
> Cope with missing /usr/sbin/prelink.
> * lib/prelink-support.exp (prelink_no):
> <result == 1 && $output is "no such file or directory">: New.
> (prelink_yes): Likewise. Return on failed prelink_no.
OK to commit.
--
Joel
next prev parent reply other threads:[~2010-07-05 17:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-29 16:18 Jan Kratochvil
2010-06-09 15:10 ` ping: " Jan Kratochvil
2010-06-29 22:09 ` Joel Brobecker
2010-07-04 10:19 ` Jan Kratochvil
2010-07-05 17:40 ` Joel Brobecker [this message]
2010-07-05 18:13 ` Jan Kratochvil
2010-07-19 15:06 ` Pedro Alves
2010-07-19 15:43 ` Daniel Jacobowitz
2010-07-28 14:26 ` Disable i18n when running the testsuite (Re: ping: [patch 5/6] testsuite: Fix prelink-support.exp without prelink installed) Pedro Alves
2010-07-28 17:36 ` Joel Brobecker
2010-07-29 14:20 ` Disable i18n when running the testsuite Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100705174015.GC2595@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox