From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14106 invoked by alias); 5 Jul 2010 17:40:36 -0000 Received: (qmail 14096 invoked by uid 22791); 5 Jul 2010 17:40:35 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 05 Jul 2010 17:40:30 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 572012BAC5E; Mon, 5 Jul 2010 13:40:29 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id qImssZHoFPCr; Mon, 5 Jul 2010 13:40:29 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 284722BAB6C; Mon, 5 Jul 2010 13:40:29 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id B4219F5895; Mon, 5 Jul 2010 10:40:15 -0700 (PDT) Date: Mon, 05 Jul 2010 17:40:00 -0000 From: Joel Brobecker To: Jan Kratochvil Cc: gdb-patches@sourceware.org Subject: Re: ping: [patch 5/6] testsuite: Fix prelink-support.exp without prelink installed Message-ID: <20100705174015.GC2595@adacore.com> References: <20100329161831.GD2940@host0.dyn.jankratochvil.net> <20100609150954.GE7183@host0.dyn.jankratochvil.net> <20100629220904.GV2595@adacore.com> <20100704101842.GE6875@host0.dyn.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100704101842.GE6875@host0.dyn.jankratochvil.net> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-07/txt/msg00082.txt.bz2 > GDB testsuite does not force English, neither dejagnu. But TCL seems to > ignore locale: That's more than good enough for me. Thanks! > There is explicitly executed /usr/sbin/prelink because on some systems > /usr/sbin is not in the default non-root $PATH. This also fixes: Good point. > Do you suggest /usr/sbin/prelink existence check, $PATH search (with > explicitly appended `/usr/sbin') or the current error message check? I think it's fine to wait until we actually find a system where the current approach is not working. So: > gdb/testsuite/ > 2010-07-04 Jan Kratochvil > Joel Brobecker > > Cope with missing /usr/sbin/prelink. > * lib/prelink-support.exp (prelink_no): > : New. > (prelink_yes): Likewise. Return on failed prelink_no. OK to commit. -- Joel