Re: ping: [patch 2/6] PIE: Attach binary even after ld.so re-prelinked underneath

[Joel Brobecker <brobecker@adacore.com>]

V> Therefore used some merged+modified comment:

Much clearer, thank you (and I'm continuing to learn as I go)...

> gdb/
> 2010-07-04  Jan Kratochvil  <jan.kratochvil@redhat.com>
> 	    Joel Brobecker  <brobecker@adacore.com>
> 
> 	* auxv.c (ld_so_xfer_auxv): Do not error on failed read of data_address.
> 
> gdb/testsuite/
> 2010-07-04  Jan Kratochvil  <jan.kratochvil@redhat.com>
> 	    Joel Brobecker  <brobecker@adacore.com>
> 
> 	* gdb.base/break-interp.exp (test_attach): Keep $interp changed.  Move

OK with the tiny changes below.

> In most cases of a PIE running under valgrind there is no way how to find
                                                         ^^^^^^^^^^^^^
                                                         no way to find

> # Formerly this test was testing only prelinking of $EXEC.  As the
> # prelink command prelinks automatically even all $EXEC's libraries
                    automatically prelinks all of $EXEC's libraries,
                    (the comma is important)
> # even $INTERP got prelinked.  Therefore we formerly had to
                                        ^^^ Therefore,
> # `[copy $interp_saved $interp]' to make $INTERP not affected by
> # this prelinking of $EXEC.
> #
> # But now we need to test even prelinking of $INTERP.  We could
> # create a separate test to test just the $INTERP prelinking.  For
> # the test simplicity we merged this test and the test above by not
    ^^^^ test simplicity, we merged [...]
> # restoring $INTERP after $EXEC prelink.  $INTERP gets restored 
> # later below.

-- 
Joel