From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1211 invoked by alias); 5 Jul 2010 17:15:04 -0000 Received: (qmail 1161 invoked by uid 22791); 5 Jul 2010 17:15:03 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 05 Jul 2010 17:14:58 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 02C592BAC50; Mon, 5 Jul 2010 13:14:57 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 1tKIh+4+0yVS; Mon, 5 Jul 2010 13:14:56 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id C178B2BAC4B; Mon, 5 Jul 2010 13:14:56 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 5D649F5895; Mon, 5 Jul 2010 10:14:43 -0700 (PDT) Date: Mon, 05 Jul 2010 17:15:00 -0000 From: Joel Brobecker To: Jan Kratochvil Cc: gdb-patches@sourceware.org Subject: Re: ping: [patch 2/6] PIE: Attach binary even after ld.so re-prelinked underneath Message-ID: <20100705171443.GZ2595@adacore.com> References: <20100329161657.GA2940@host0.dyn.jankratochvil.net> <20100609150815.GB7183@host0.dyn.jankratochvil.net> <20100629182132.GS2595@adacore.com> <20100704101653.GB6875@host0.dyn.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100704101653.GB6875@host0.dyn.jankratochvil.net> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-07/txt/msg00078.txt.bz2 V> Therefore used some merged+modified comment: Much clearer, thank you (and I'm continuing to learn as I go)... > gdb/ > 2010-07-04 Jan Kratochvil > Joel Brobecker > > * auxv.c (ld_so_xfer_auxv): Do not error on failed read of data_address. > > gdb/testsuite/ > 2010-07-04 Jan Kratochvil > Joel Brobecker > > * gdb.base/break-interp.exp (test_attach): Keep $interp changed. Move OK with the tiny changes below. > In most cases of a PIE running under valgrind there is no way how to find ^^^^^^^^^^^^^ no way to find > # Formerly this test was testing only prelinking of $EXEC. As the > # prelink command prelinks automatically even all $EXEC's libraries automatically prelinks all of $EXEC's libraries, (the comma is important) > # even $INTERP got prelinked. Therefore we formerly had to ^^^ Therefore, > # `[copy $interp_saved $interp]' to make $INTERP not affected by > # this prelinking of $EXEC. > # > # But now we need to test even prelinking of $INTERP. We could > # create a separate test to test just the $INTERP prelinking. For > # the test simplicity we merged this test and the test above by not ^^^^ test simplicity, we merged [...] > # restoring $INTERP after $EXEC prelink. $INTERP gets restored > # later below. -- Joel