From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: dan@codesourcery.com
Cc: tromey@redhat.com, gdb-patches@sourceware.org
Subject: Re: [2/4] RFC: check psymtabs_addrmap before reading FDEs
Date: Thu, 01 Jul 2010 16:13:00 -0000 [thread overview]
Message-ID: <201007011610.o61GAL3u023357@glazunov.sibelius.xs4all.nl> (raw)
In-Reply-To: <20100701154058.GA25227@caradoc.them.org> (message from Daniel Jacobowitz on Thu, 1 Jul 2010 11:41:01 -0400)
> Date: Thu, 1 Jul 2010 11:41:01 -0400
> From: Daniel Jacobowitz <dan@codesourcery.com>
>
> On Wed, Jun 30, 2010 at 04:37:23PM -0600, Tom Tromey wrote:
> > This patch changes dwarf2_frame_find_fde to check psymtabs_addrmap
> > before trying to read the FDE data.
> >
> > I am not totally convinced this is safe, so comments are especially
> > appreciated here.
>
> This doesn't sound right. I don't know how any of the psymtab changes
> work, but there shouldn't be a link between psymtabs and FDEs at all;
> they don't have to correspond. Wouldn't this break a library with
> .debug_frame for all code, and .debug_info for only one input object?
I agree with Daniel here.
next prev parent reply other threads:[~2010-07-01 16:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-30 22:37 Tom Tromey
2010-07-01 15:41 ` Daniel Jacobowitz
2010-07-01 16:13 ` Mark Kettenis [this message]
2010-07-01 16:56 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201007011610.o61GAL3u023357@glazunov.sibelius.xs4all.nl \
--to=mark.kettenis@xs4all.nl \
--cc=dan@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox