From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-74123-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 20434 invoked by alias); 1 Jul 2010 16:13:22 -0000
Received: (qmail 20424 invoked by uid 22791); 1 Jul 2010 16:13:21 -0000
X-SWARE-Spam-Status: No, hits=-2.1 required=5.0	tests=AWL,BAYES_00,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from sibelius.xs4all.nl (HELO glazunov.sibelius.xs4all.nl) (83.163.83.176)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 01 Jul 2010 16:13:15 +0000
Received: from glazunov.sibelius.xs4all.nl (kettenis@localhost [127.0.0.1])	by glazunov.sibelius.xs4all.nl (8.14.3/8.14.3) with ESMTP id o61GAMCS008502;	Thu, 1 Jul 2010 18:10:22 +0200 (CEST)
Received: (from kettenis@localhost)	by glazunov.sibelius.xs4all.nl (8.14.3/8.14.3/Submit) id o61GAL3u023357;	Thu, 1 Jul 2010 18:10:21 +0200 (CEST)
Date: Thu, 01 Jul 2010 16:13:00 -0000
Message-Id: <201007011610.o61GAL3u023357@glazunov.sibelius.xs4all.nl>
From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: dan@codesourcery.com
CC: tromey@redhat.com, gdb-patches@sourceware.org
In-reply-to: <20100701154058.GA25227@caradoc.them.org> (message from Daniel	Jacobowitz on Thu, 1 Jul 2010 11:41:01 -0400)
Subject: Re: [2/4] RFC: check psymtabs_addrmap before reading FDEs
References: <m31vboqh98.fsf@fleche.redhat.com> <20100701154058.GA25227@caradoc.them.org>
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-07/txt/msg00014.txt.bz2

> Date: Thu, 1 Jul 2010 11:41:01 -0400
> From: Daniel Jacobowitz <dan@codesourcery.com>
> 
> On Wed, Jun 30, 2010 at 04:37:23PM -0600, Tom Tromey wrote:
> > This patch changes dwarf2_frame_find_fde to check psymtabs_addrmap
> > before trying to read the FDE data.
> > 
> > I am not totally convinced this is safe, so comments are especially
> > appreciated here.
> 
> This doesn't sound right.  I don't know how any of the psymtab changes
> work, but there shouldn't be a link between psymtabs and FDEs at all;
> they don't have to correspond.  Wouldn't this break a library with
> .debug_frame for all code, and .debug_info for only one input object?

I agree with Daniel here.