From: "Ulrich Weigand" <uweigand@de.ibm.com>
To: tromey@redhat.com
Cc: gdb-patches@sourceware.org
Subject: Re: [rfc] DWARF expression evaluation vs. GDB address encoding problems
Date: Fri, 25 Jun 2010 13:02:00 -0000 [thread overview]
Message-ID: <201006251302.o5PD2R97026158@d12av02.megacenter.de.ibm.com> (raw)
In-Reply-To: <m3tyos8inm.fsf@fleche.redhat.com> from "Tom Tromey" at Jun 24, 2010 11:06:21 AM
Tom Tromey wrote:
> >>>>> "Ulrich" == Ulrich Weigand <uweigand@de.ibm.com> writes:
>
> Ulrich> In fact, this seems the real problem to me: operations on the DWARF
> Ulrich> stack should really use the target pointer / address representation;
> Ulrich> only after the computation is complete should the value be converted
> Ulrich> into the GDB internal address representation (CORE_ADDR).
>
> This makes sense to me.
>
> Ulrich> As a side effect, we no longer need to employ the value machinery
> Ulrich> to perform binary operations on the DWARF stack.
>
> Nice.
>
> Ulrich> Tom, does this look reasonable to you?
>
> Yes, thanks.
OK, thanks for the review!
I've checked the patch in now.
Bye,
Ulrich
--
Dr. Ulrich Weigand
GNU Toolchain for Linux on System z and Cell BE
Ulrich.Weigand@de.ibm.com
prev parent reply other threads:[~2010-06-25 13:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-23 20:30 Ulrich Weigand
2010-06-24 17:06 ` Tom Tromey
2010-06-25 13:02 ` Ulrich Weigand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201006251302.o5PD2R97026158@d12av02.megacenter.de.ibm.com \
--to=uweigand@de.ibm.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox