From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12835 invoked by alias); 25 Jun 2010 13:02:41 -0000 Received: (qmail 12565 invoked by uid 22791); 25 Jun 2010 13:02:40 -0000 X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 tests=AWL,BAYES_00,MSGID_FROM_MTA_HEADER,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mtagate6.de.ibm.com (HELO mtagate6.de.ibm.com) (195.212.17.166) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 25 Jun 2010 13:02:31 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate6.de.ibm.com (8.13.1/8.13.1) with ESMTP id o5PD2Tb6030267 for ; Fri, 25 Jun 2010 13:02:29 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id o5PD2SPJ1560792 for ; Fri, 25 Jun 2010 15:02:28 +0200 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id o5PD2SLR026202 for ; Fri, 25 Jun 2010 15:02:28 +0200 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with SMTP id o5PD2R97026158; Fri, 25 Jun 2010 15:02:27 +0200 Message-Id: <201006251302.o5PD2R97026158@d12av02.megacenter.de.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Fri, 25 Jun 2010 15:02:27 +0200 Subject: Re: [rfc] DWARF expression evaluation vs. GDB address encoding problems To: tromey@redhat.com Date: Fri, 25 Jun 2010 13:02:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org In-Reply-To: from "Tom Tromey" at Jun 24, 2010 11:06:21 AM MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-06/txt/msg00574.txt.bz2 Tom Tromey wrote: > >>>>> "Ulrich" == Ulrich Weigand writes: > > Ulrich> In fact, this seems the real problem to me: operations on the DWARF > Ulrich> stack should really use the target pointer / address representation; > Ulrich> only after the computation is complete should the value be converted > Ulrich> into the GDB internal address representation (CORE_ADDR). > > This makes sense to me. > > Ulrich> As a side effect, we no longer need to employ the value machinery > Ulrich> to perform binary operations on the DWARF stack. > > Nice. > > Ulrich> Tom, does this look reasonable to you? > > Yes, thanks. OK, thanks for the review! I've checked the patch in now. Bye, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com