Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org
Cc: "Pierre Muller" <pierre.muller@ics-cnrs.unistra.fr>
Subject: Re: [RFA] testsuite avoid tcl error in gdb.threads/gcore-thread.exp
Date: Wed, 23 Jun 2010 14:42:00 -0000	[thread overview]
Message-ID: <201006231542.12328.pedro@codesourcery.com> (raw)
In-Reply-To: <000901cb12dc$40c1f830$c245e890$@muller@ics-cnrs.unistra.fr>

On Wednesday 23 June 2010 14:59:09, Pierre Muller wrote:

>   Tested on gcc16 (it works again, hurrah!)
> no changes.

I, and more importantly I guess anyone reading the archives in a
few years, don't know what gcc16 is.  I guess it to be a machine in
the gcc compile farm, and I guess it to be running linux, but I don't
know for sure.  I don't know if it is x86, x86-64 or something else.  Can
you please state x86_64-linux, or something like that instead of
assuming everyone else is using the gcc compile farm?

>   OK to commit?

Yes, thanks.  I was going to suggest fixing gcore.exp too, but
it was already fixed similarly at some point:

2007-05-14  Markus Deuling  <deuling@de.ibm.com>

        * gdb.base/gcore.exp: Initialize variable core_supported.

>  set escapedfilename [string_to_regexp ${objdir}/${subdir}/gcore.test]
>  # Drop corefile
> +global core_supported
> +set core_supported 0
> +

Pedantically, you don't need that "global" statement anymore.

-- 
Pedro Alves


  reply	other threads:[~2010-06-23 14:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-23 13:59 Pierre Muller
2010-06-23 14:42 ` Pedro Alves [this message]
2010-06-23 15:31   ` Pierre Muller
     [not found]   ` <5627205469024062490@unknownmsgid>
2010-06-26 17:16     ` Doug Evans

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201006231542.12328.pedro@codesourcery.com \
    --to=pedro@codesourcery.com \
    --cc=gdb-patches@sourceware.org \
    --cc=pierre.muller@ics-cnrs.unistra.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox