From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18909 invoked by alias); 23 Jun 2010 14:42:25 -0000 Received: (qmail 18900 invoked by uid 22791); 23 Jun 2010 14:42:24 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 23 Jun 2010 14:42:19 +0000 Received: (qmail 23413 invoked from network); 23 Jun 2010 14:42:17 -0000 Received: from unknown (HELO orlando.localnet) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 23 Jun 2010 14:42:17 -0000 From: Pedro Alves To: gdb-patches@sourceware.org Subject: Re: [RFA] testsuite avoid tcl error in gdb.threads/gcore-thread.exp Date: Wed, 23 Jun 2010 14:42:00 -0000 User-Agent: KMail/1.13.2 (Linux/2.6.32-22-generic; KDE/4.4.2; x86_64; ; ) Cc: "Pierre Muller" References: <000901cb12dc$40c1f830$c245e890$@muller@ics-cnrs.unistra.fr> In-Reply-To: <000901cb12dc$40c1f830$c245e890$@muller@ics-cnrs.unistra.fr> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201006231542.12328.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-06/txt/msg00499.txt.bz2 On Wednesday 23 June 2010 14:59:09, Pierre Muller wrote: > Tested on gcc16 (it works again, hurrah!) > no changes. I, and more importantly I guess anyone reading the archives in a few years, don't know what gcc16 is. I guess it to be a machine in the gcc compile farm, and I guess it to be running linux, but I don't know for sure. I don't know if it is x86, x86-64 or something else. Can you please state x86_64-linux, or something like that instead of assuming everyone else is using the gcc compile farm? > OK to commit? Yes, thanks. I was going to suggest fixing gcore.exp too, but it was already fixed similarly at some point: 2007-05-14 Markus Deuling * gdb.base/gcore.exp: Initialize variable core_supported. > set escapedfilename [string_to_regexp ${objdir}/${subdir}/gcore.test] > # Drop corefile > +global core_supported > +set core_supported 0 > + Pedantically, you don't need that "global" statement anymore. -- Pedro Alves