From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Chris Moller <cmoller@redhat.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [patch] pr11371 conditional watchpoints with a function in the condition.
Date: Fri, 04 Jun 2010 20:55:00 -0000 [thread overview]
Message-ID: <20100604201410.GA4130@host0.dyn.jankratochvil.net> (raw)
In-Reply-To: <4C0936B5.9080002@redhat.com>
On Fri, 04 Jun 2010 19:24:05 +0200, Chris Moller wrote:
> + if (b->type != bp_watchpoint && b->type != bp_hardware_watchpoint &&
> + b->enable_state != bp_call_disabled)
`&&' should be on the second line.
http://www.gnu.org/prep/standards/standards.html#Formatting
When you split an expression into multiple lines, split it before an
operator, not after one.
> +Running ../../../src/gdb/testsuite/gdb.base/pr11371.exp ...
> +PASS: gdb.base/pr11371.exp: watch aa if cond(aa)
> +PASS: gdb.base/pr11371.exp: run to conditional watchpoint
> +PASS: gdb.base/pr11371.exp: run to conditional watchpoint
> +PASS: gdb.base/pr11371.exp: run to conditional watchpoint
Apparently you have written a new testcase but forgot to attach it.
I have not tried to do real a review without the testcase.
Thanks,
Jan
next prev parent reply other threads:[~2010-06-04 20:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-04 17:24 Chris Moller
2010-06-04 20:55 ` Jan Kratochvil [this message]
2010-06-04 20:34 ` Chris Moller
2010-06-04 22:54 ` Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100604201410.GA4130@host0.dyn.jankratochvil.net \
--to=jan.kratochvil@redhat.com \
--cc=cmoller@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox