From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20181 invoked by alias); 4 Jun 2010 20:55:26 -0000 Received: (qmail 20173 invoked by uid 22791); 4 Jun 2010 20:55:25 -0000 X-SWARE-Spam-Status: No, hits=-5.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 04 Jun 2010 20:55:21 +0000 Received: from int-mx05.intmail.prod.int.phx2.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.18]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o54KtJFX015448 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 4 Jun 2010 16:55:19 -0400 Received: from host0.dyn.jankratochvil.net (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx05.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o54KEBLx010644 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 4 Jun 2010 16:14:13 -0400 Received: from host0.dyn.jankratochvil.net (localhost [127.0.0.1]) by host0.dyn.jankratochvil.net (8.14.4/8.14.4) with ESMTP id o54KEBs0004351; Fri, 4 Jun 2010 22:14:11 +0200 Received: (from jkratoch@localhost) by host0.dyn.jankratochvil.net (8.14.4/8.14.4/Submit) id o54KEAUh004350; Fri, 4 Jun 2010 22:14:10 +0200 Date: Fri, 04 Jun 2010 20:55:00 -0000 From: Jan Kratochvil To: Chris Moller Cc: "gdb-patches@sourceware.org" Subject: Re: [patch] pr11371 conditional watchpoints with a function in the condition. Message-ID: <20100604201410.GA4130@host0.dyn.jankratochvil.net> References: <4C0936B5.9080002@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4C0936B5.9080002@redhat.com> User-Agent: Mutt/1.5.20 (2009-12-10) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-06/txt/msg00134.txt.bz2 On Fri, 04 Jun 2010 19:24:05 +0200, Chris Moller wrote: > + if (b->type != bp_watchpoint && b->type != bp_hardware_watchpoint && > + b->enable_state != bp_call_disabled) `&&' should be on the second line. http://www.gnu.org/prep/standards/standards.html#Formatting When you split an expression into multiple lines, split it before an operator, not after one. > +Running ../../../src/gdb/testsuite/gdb.base/pr11371.exp ... > +PASS: gdb.base/pr11371.exp: watch aa if cond(aa) > +PASS: gdb.base/pr11371.exp: run to conditional watchpoint > +PASS: gdb.base/pr11371.exp: run to conditional watchpoint > +PASS: gdb.base/pr11371.exp: run to conditional watchpoint Apparently you have written a new testcase but forgot to attach it. I have not tried to do real a review without the testcase. Thanks, Jan