From: Joel Brobecker <brobecker@adacore.com>
To: Pierre Muller <pierre.muller@ics-cnrs.unistra.fr>
Cc: 'Doug Evans' <dje@google.com>, gdb-patches@sourceware.org
Subject: Re: New ARI warning Wed May 26 01:54:51 UTC 2010
Date: Wed, 02 Jun 2010 23:08:00 -0000 [thread overview]
Message-ID: <20100602230819.GI3019@adacore.com> (raw)
In-Reply-To: <000901cafcaa$80ddf470$8299dd50$@muller@ics-cnrs.unistra.fr>
> > > gdb/python/py-cmd.c:192: Â Â Â Â error ("%s", msg);
> > >
> >
> > There were already a couple of uses of error ("%s", ...) so I figured
> > it was safe.
>
> Of course, translation of "%s" into another language does make sense!
>
> > OOC, is this why source.c has:
> >
> > error (("%s"), msg);
>
> I suspect that the braces around "%s" are exactly here for that reason:
> they avoid getting this ARI report.
> Does anyone have another idea of the utility of such a wrapping?
>
> I could probably try to improve the ARI rule
> so that it does not complain if the string is just "%s",
> but I would like to be sure that I am not missing some information here.
I don't think anyone really answered the above. I don't see any issue
either way, and I don't have a preference. ISTM that the simplest would
probably be to use ("%s"), instead of adding an exception for "%s".
--
Joel
prev parent reply other threads:[~2010-06-02 23:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-26 2:47 GDB Administrator
2010-05-26 4:44 ` Doug Evans
2010-05-26 9:06 ` Pierre Muller
2010-06-02 23:08 ` Joel Brobecker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100602230819.GI3019@adacore.com \
--to=brobecker@adacore.com \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=pierre.muller@ics-cnrs.unistra.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox