From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26226 invoked by alias); 2 Jun 2010 23:08:33 -0000 Received: (qmail 26214 invoked by uid 22791); 2 Jun 2010 23:08:31 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 02 Jun 2010 23:08:27 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id D42972BAC90; Wed, 2 Jun 2010 19:08:25 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id HLkEl1fLrdvT; Wed, 2 Jun 2010 19:08:25 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 688D22BAC8D; Wed, 2 Jun 2010 19:08:24 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id B39C6F58FA; Wed, 2 Jun 2010 16:08:19 -0700 (PDT) Date: Wed, 02 Jun 2010 23:08:00 -0000 From: Joel Brobecker To: Pierre Muller Cc: 'Doug Evans' , gdb-patches@sourceware.org Subject: Re: New ARI warning Wed May 26 01:54:51 UTC 2010 Message-ID: <20100602230819.GI3019@adacore.com> References: <20100526015451.GA24207@sourceware.org> <000901cafcaa$80ddf470$8299dd50$@muller@ics-cnrs.unistra.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <000901cafcaa$80ddf470$8299dd50$@muller@ics-cnrs.unistra.fr> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-06/txt/msg00091.txt.bz2 > > > gdb/python/py-cmd.c:192:        error ("%s", msg); > > > > > > > There were already a couple of uses of error ("%s", ...) so I figured > > it was safe. > > Of course, translation of "%s" into another language does make sense! > > > OOC, is this why source.c has: > > > > error (("%s"), msg); > > I suspect that the braces around "%s" are exactly here for that reason: > they avoid getting this ARI report. > Does anyone have another idea of the utility of such a wrapping? > > I could probably try to improve the ARI rule > so that it does not complain if the string is just "%s", > but I would like to be sure that I am not missing some information here. I don't think anyone really answered the above. I don't see any issue either way, and I don't have a preference. ISTM that the simplest would probably be to use ("%s"), instead of adding an exception for "%s". -- Joel