Re: [RFA] gdb.trace/*.exp send_gdb vs. gdb_test

[Pedro Alves <pedro@codesourcery.com>]

On Wednesday 02 June 2010 20:42:48, Michael Snyder wrote:
> > I took a look at your patch.
> > 
> >> -send_gdb "list $baseline, +12\n"
> >> -gdb_expect {
> >> +gdb_test_multiple "list $baseline, +12" "all tests in this module will fail" {
> >>      -re "\[\r\n\](\[0-9\]+).*gdbtestline 1 " {
> >>         set testline1 $expect_out(1,string)
> >>         exp_continue
> >> @@ -108,7 +107,7 @@ all tests in this module will fail."
> >>             untested backtrace.exp
> >>             return -1
> >>  all tests in this module will fail."
> >> -    } 
> >> +    }
> >>  }
> >>  
> > 
> > Can you do the return outside of gdb_test_multiple please?
> > I saw a few other instances in tfind.exp.  Otherwise, looked fine.
> 
> Done and committed.  By the way, would you take a look at the
> diff just above?  What is "all tests in this module will fail"
> doing there?  The same thing appears in both backtrace.exp and
> report.exp.
> 

Huh!  It looks like it got left behind when somebody removed
gdb_supported_entire_file calls from these tests.  I see things
like these in gdb 6.0:

    gdb_expect {
        -re "MIS-MATCHED.*$gdb_prompt $" {
            gdb_suppress_entire_file "Symbol file does not match target!
            all tests in this module will fail.";
        }

-- 
Pedro Alves