From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-73481-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 21959 invoked by alias); 2 Jun 2010 21:58:10 -0000
Received: (qmail 21949 invoked by uid 22791); 2 Jun 2010 21:58:09 -0000
X-SWARE-Spam-Status: No, hits=-2.1 required=5.0	tests=AWL,BAYES_00,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 02 Jun 2010 21:58:06 +0000
Received: (qmail 10114 invoked from network); 2 Jun 2010 21:58:04 -0000
Received: from unknown (HELO orlando.localnet) (pedro@127.0.0.2)  by mail.codesourcery.com with ESMTPA; 2 Jun 2010 21:58:04 -0000
From: Pedro Alves <pedro@codesourcery.com>
To: Michael Snyder <msnyder@vmware.com>
Subject: Re: [RFA] gdb.trace/*.exp send_gdb vs. gdb_test
Date: Wed, 02 Jun 2010 21:58:00 -0000
User-Agent: KMail/1.13.2 (Linux/2.6.32-22-generic; KDE/4.4.2; x86_64; ; )
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>, Stan Shebs <stan@codesourcery.com>
References: <4BFEB77D.4080107@vmware.com> <201005272350.40581.pedro@codesourcery.com> <4C06B438.1090508@vmware.com>
In-Reply-To: <4C06B438.1090508@vmware.com>
MIME-Version: 1.0
Content-Type: Text/Plain;  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Message-Id: <201006022258.02225.pedro@codesourcery.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-06/txt/msg00074.txt.bz2

On Wednesday 02 June 2010 20:42:48, Michael Snyder wrote:
> > I took a look at your patch.
> > 
> >> -send_gdb "list $baseline, +12\n"
> >> -gdb_expect {
> >> +gdb_test_multiple "list $baseline, +12" "all tests in this module will fail" {
> >>      -re "\[\r\n\](\[0-9\]+).*gdbtestline 1 " {
> >>         set testline1 $expect_out(1,string)
> >>         exp_continue
> >> @@ -108,7 +107,7 @@ all tests in this module will fail."
> >>             untested backtrace.exp
> >>             return -1
> >>  all tests in this module will fail."
> >> -    } 
> >> +    }
> >>  }
> >>  
> > 
> > Can you do the return outside of gdb_test_multiple please?
> > I saw a few other instances in tfind.exp.  Otherwise, looked fine.
> 
> Done and committed.  By the way, would you take a look at the
> diff just above?  What is "all tests in this module will fail"
> doing there?  The same thing appears in both backtrace.exp and
> report.exp.
> 

Huh!  It looks like it got left behind when somebody removed
gdb_supported_entire_file calls from these tests.  I see things
like these in gdb 6.0:

    gdb_expect {
        -re "MIS-MATCHED.*$gdb_prompt $" {
            gdb_suppress_entire_file "Symbol file does not match target!
            all tests in this module will fail.";
        }

-- 
Pedro Alves