From: Joel Brobecker <brobecker@adacore.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] Extend Fortran detection filename extensions
Date: Wed, 02 Jun 2010 22:52:00 -0000 [thread overview]
Message-ID: <20100602225241.GG3019@adacore.com> (raw)
In-Reply-To: <20100602223632.GA2545@host0.dyn.jankratochvil.net>
> > > +# Test automatic language detection before the inferior starts.
> > > +gdb_test "p modmany::var_i" " = 14" "stopped language detection"
> >
> > Why not just do "show language"?
>
> I believe this testcase should be in place as it tests it all together.
>
> There could be probably also an isolated new testcase. I was not sure if
> there would not be one day changes in how Fortran language variants get
> detected and called in `show language'. But I understand in such case even
> the testcases must be changed.
>
> Should I submit a separate testfile for it?
It's not very important, IMO. I'm happy with the above especially if
you adjust the comment to say that this *also* verifies that the language
is currently fortran, since the test itself seems to be important as well.
--
Joel
prev parent reply other threads:[~2010-06-02 22:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-02 21:41 Jan Kratochvil
2010-06-02 22:03 ` Tom Tromey
2010-06-02 23:03 ` Jan Kratochvil
2010-06-02 22:06 ` Joel Brobecker
2010-06-02 22:37 ` Jan Kratochvil
2010-06-02 22:52 ` Joel Brobecker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100602225241.GG3019@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox