From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3282 invoked by alias); 2 Jun 2010 22:52:52 -0000 Received: (qmail 3272 invoked by uid 22791); 2 Jun 2010 22:52:51 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 02 Jun 2010 22:52:47 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 39DAB2BAC83; Wed, 2 Jun 2010 18:52:46 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id l6Iz8U-8-NE1; Wed, 2 Jun 2010 18:52:46 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 05EDA2BAC76; Wed, 2 Jun 2010 18:52:45 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 22DC8F58FA; Wed, 2 Jun 2010 15:52:41 -0700 (PDT) Date: Wed, 02 Jun 2010 22:52:00 -0000 From: Joel Brobecker To: Jan Kratochvil Cc: gdb-patches@sourceware.org Subject: Re: [patch] Extend Fortran detection filename extensions Message-ID: <20100602225241.GG3019@adacore.com> References: <20100602214059.GB30562@host0.dyn.jankratochvil.net> <20100602220622.GD3019@adacore.com> <20100602223632.GA2545@host0.dyn.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100602223632.GA2545@host0.dyn.jankratochvil.net> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-06/txt/msg00087.txt.bz2 > > > +# Test automatic language detection before the inferior starts. > > > +gdb_test "p modmany::var_i" " = 14" "stopped language detection" > > > > Why not just do "show language"? > > I believe this testcase should be in place as it tests it all together. > > There could be probably also an isolated new testcase. I was not sure if > there would not be one day changes in how Fortran language variants get > detected and called in `show language'. But I understand in such case even > the testcases must be changed. > > Should I submit a separate testfile for it? It's not very important, IMO. I'm happy with the above especially if you adjust the comment to say that this *also* verifies that the language is currently fortran, since the test itself seems to be important as well. -- Joel