From: Joel Brobecker <brobecker@adacore.com>
To: Sergio Durigan Junior <sergiodj@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Remove unused exp_opcodes
Date: Tue, 01 Jun 2010 21:59:00 -0000 [thread overview]
Message-ID: <20100601215926.GU3019@adacore.com> (raw)
In-Reply-To: <201006011748.43410.sergiodj@redhat.com>
> 2010-06-01 Sergio Durigan Junior <sergiodj@redhat.com>
>
> * expprint.c (print_subexp_standard): Remove exp_opcodes BINOP_INCL,
> BINOP_EXCL.
> (op_name_standard): Remove exp_opcodes BINOP_INCL, BINOP_EXCL,
> UNOP_LOWER, UNOP_UPPER, UNOP_LENGTH.
> (dump_subexp_body_standard): Remove exp_opcodes BINOP_INCL,
> BINOP_EXCL, UNOP_LOWER, UNOP_UPPER, UNOP_LENGTH, UNOP_CARD,
> UNOP_CHMAX, UNOP_CHMIN.
> * expression.h (enum exp_opcode) <BINOP_INCL, BINOP_EXCL,
> UNOP_LOWER, UNOP_UPPER, UNOP_LENGTH, UNOP_CARD, UNOP_CHMAX,
> UNOP_CHMIN>: Remove opcodes.
Thanks for doing that cleanup. This patch is OK.
I'll confess that I am not quite sure whether you're supposed to close
the '<' at the end of the line, or whether it can continue on the next
line like you did. I don't think it's a huge deal, but we can fix that
if someone knows and it turns out to be wrong...
--
Joel
next prev parent reply other threads:[~2010-06-01 21:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-01 21:37 Sergio Durigan Junior
2010-06-01 21:59 ` Joel Brobecker [this message]
2010-06-01 22:25 ` Tom Tromey
2010-06-02 0:41 ` Sergio Durigan Junior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100601215926.GU3019@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=sergiodj@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox