From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24917 invoked by alias); 1 Jun 2010 21:59:54 -0000 Received: (qmail 24908 invoked by uid 22791); 1 Jun 2010 21:59:53 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 01 Jun 2010 21:59:34 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 113332BABAA; Tue, 1 Jun 2010 17:59:33 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id kpNubU+mSf3a; Tue, 1 Jun 2010 17:59:32 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id CDBD22BABA9; Tue, 1 Jun 2010 17:59:32 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 83181F58FA; Tue, 1 Jun 2010 14:59:26 -0700 (PDT) Date: Tue, 01 Jun 2010 21:59:00 -0000 From: Joel Brobecker To: Sergio Durigan Junior Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Remove unused exp_opcodes Message-ID: <20100601215926.GU3019@adacore.com> References: <201006011748.43410.sergiodj@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201006011748.43410.sergiodj@redhat.com> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-06/txt/msg00030.txt.bz2 > 2010-06-01 Sergio Durigan Junior > > * expprint.c (print_subexp_standard): Remove exp_opcodes BINOP_INCL, > BINOP_EXCL. > (op_name_standard): Remove exp_opcodes BINOP_INCL, BINOP_EXCL, > UNOP_LOWER, UNOP_UPPER, UNOP_LENGTH. > (dump_subexp_body_standard): Remove exp_opcodes BINOP_INCL, > BINOP_EXCL, UNOP_LOWER, UNOP_UPPER, UNOP_LENGTH, UNOP_CARD, > UNOP_CHMAX, UNOP_CHMIN. > * expression.h (enum exp_opcode) UNOP_LOWER, UNOP_UPPER, UNOP_LENGTH, UNOP_CARD, UNOP_CHMAX, > UNOP_CHMIN>: Remove opcodes. Thanks for doing that cleanup. This patch is OK. I'll confess that I am not quite sure whether you're supposed to close the '<' at the end of the line, or whether it can continue on the next line like you did. I don't think it's a huge deal, but we can fix that if someone knows and it turns out to be wrong... -- Joel