From: Pedro Alves <pedro@codesourcery.com>
To: tromey@redhat.com
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA] New qRelocInsn RSP packet, docs and NEWS.
Date: Thu, 27 May 2010 20:14:00 -0000 [thread overview]
Message-ID: <201005272109.22413.pedro@codesourcery.com> (raw)
In-Reply-To: <m3typtf779.fsf@fleche.redhat.com>
On Thursday 27 May 2010 20:58:02, Tom Tromey wrote:
> >>>>> "Pedro" == Pedro Alves <pedro@codesourcery.com> writes:
>
> Pedro> Index: src/gdb/remote.c
> Pedro> ===================================================================
> Pedro> --- src.orig/gdb/remote.c 2010-05-24 12:28:42.000000000 +0100
> Pedro> +++ src/gdb/remote.c 2010-05-24 13:14:56.000000000 +0100
> Pedro> @@ -242,6 +242,8 @@ static void remote_terminal_ours (void);
>
> Pedro> static int remote_read_description_p (struct target_ops *target);
>
> Pedro> +char *unpack_varlen_hex (char *buff, ULONGEST *result);
>
> It seems like this declaration could go in tracepoint.h.
This function does live in remote.c, but it's defined further down, close to
its siblings. tracepoint.c is also reusing it since not to long ago (since
tracing moved to target_ops). remote.h would make a bit more sense though
one could argue it could also live in a shared utils.c-kind of file nowadays.
--
Pedro Alves
next prev parent reply other threads:[~2010-05-27 20:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-24 15:30 Pedro Alves
2010-05-24 18:23 ` Eli Zaretskii
2010-05-26 18:28 ` Pedro Alves
2010-05-25 16:55 ` Joel Brobecker
2010-05-27 19:58 ` Tom Tromey
2010-05-27 20:14 ` Pedro Alves [this message]
2010-05-27 20:39 ` Tom Tromey
2010-05-27 21:03 ` Pedro Alves
2010-05-27 20:43 ` Pedro Alves
2010-06-01 19:10 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201005272109.22413.pedro@codesourcery.com \
--to=pedro@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox